Ayal Baron has posted comments on this change. Change subject: Marking del/zero volumes in blockSD class. ......................................................................
Patch Set 2: (3 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2013-02-27 11:53:36 +0200 Line 4: Commit: Eduardo Warszawski <[email protected]> Line 5: CommitDate: 2013-03-11 10:04:59 +0200 Line 6: Line 7: Marking del/zero volumes in blockSD class. Need to explain that delete today is not atomic since lvremove of multiple LVs can partially fail (e.g. since volume is open) leaving some volumes intact and others deleted. Marking before delete will enable garbage collection in such cases Line 8: Line 9: Related to: BZ#905038, BZ#910013, BZ#875708 Line 10: Line 11: Change-Id: I747bc2218e0b2cc256dd352ad890143c7d354bd8 .................................................... File vdsm/storage/blockSD.py Line 976: Line 977: Mark for delete just in case that lvremove [lvs] success partialy. Line 978: Mark for zero just in case that zero process is interrupted. Line 979: Line 980: Tagging is preferably than rename since is can be done in one lvm s/preferably than/preferable to/ s/is/it/ s/one/a single/ Line 981: operation and is resilent to open LV's, etc. Line 982: """ Line 983: try: Line 984: lvm.changelv(sdUUID, volUUIDs, (("-a", "y"), Line 977: Mark for delete just in case that lvremove [lvs] success partialy. Line 978: Mark for zero just in case that zero process is interrupted. Line 979: Line 980: Tagging is preferably than rename since is can be done in one lvm Line 981: operation and is resilent to open LV's, etc. s/resilent/resilient/ s/LV's/LVs/ Line 982: """ Line 983: try: Line 984: lvm.changelv(sdUUID, volUUIDs, (("-a", "y"), Line 985: ("--deltag", blockVolume.TAG_PREFIX_IMAGE + imgUUID), -- To view, visit http://gerrit.ovirt.org/12545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I747bc2218e0b2cc256dd352ad890143c7d354bd8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Paikov <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Gadi Ickowicz <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
