Eduardo has posted comments on this change. Change subject: Marking del/zero volumes in blockSD class. ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/storage/blockSD.py Line 992: raise Line 993: Line 994: def deleteImage(self, sdUUID, imgUUID, volsImgs): Line 995: toDel = self._getImgExclusiveVols(imgUUID, volsImgs) Line 996: self.__markForDelVols(sdUUID, imgUUID, toDel, sd.REMOVED_IMAGE_PREFIX) The tag, in sequential form, was there before. (And the illegal and...) Anyway this can be an issue only if you are changing from a new SPM to an old one during a failed or interrupt operation. Already discussed it, and Dan agrees, is better not to deal with such case. The alternatives only will raise the code complexity and not solve all he corner cases. Line 997: deleteVolumes(sdUUID, toDel) Line 998: self.rmDCImgDir(imgUUID, volsImgs) Line 999: Line 1000: def zeroImage(self, sdUUID, imgUUID, volsImgs): -- To view, visit http://gerrit.ovirt.org/12545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I747bc2218e0b2cc256dd352ad890143c7d354bd8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Paikov <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Gadi Ickowicz <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
