Eduardo has posted comments on this change. Change subject: Marking del/zero volumes in blockSD class. ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm/storage/blockSD.py Line 998: self.rmDCImgDir(imgUUID, volsImgs) Line 999: Line 1000: def zeroImage(self, sdUUID, imgUUID, volsImgs): Line 1001: toZero = self._getImgExclusiveVols(imgUUID, volsImgs) Line 1002: self.__markForDelVols(sdUUID, imgUUID, toZero, sd.ZEROED_IMAGE_PREFIX) The old host will report the existence of an image called "_remove_me_zero_imgUUID", unknown for the engine. On a failed deleteImage operation SPM should not be re-elected. Line 1003: zeroImgVolumes(sdUUID, imgUUID, toZero) Line 1004: self.rmDCImgDir(imgUUID, volsImgs) Line 1005: Line 1006: def getAllVolumes(self): -- To view, visit http://gerrit.ovirt.org/12545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I747bc2218e0b2cc256dd352ad890143c7d354bd8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Paikov <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Gadi Ickowicz <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
