Dan Kenigsberg has posted comments on this change.
Change subject: Work in progress: First commit for custom device properties.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
nice! this turned out simpler than I thought!
I'm waiting to see what are your plans for before_vm_create... (that can be
kept in a different patch, if you like).
....................................................
File tests/hooksTests.py
Line 120: script.write(code)
Line 121: os.chmod(script.name, 0775)
Line 122: script.close()
Line 123:
Line 124: result = hooks._runHooksDir("oVirt", dirName,
what does this adds over test_runHooksDir()?
how about testing your newly-tweaked before_nic_hotplug() here?
Line 125: params={'customProperty': '
rocks!'})
--
To view, visit http://gerrit.ovirt.org/13124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1684c3bcf8838b43c7856f3794f1bffd8c4b28c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
