Assaf Muller has posted comments on this change.
Change subject: Work in progress: First commit for custom device properties.
......................................................................
Patch Set 1: (1 inline comment)
Replied to comment in code.
I will add the documentation changes in the upcoming patch set.
....................................................
File tests/hooksTests.py
Line 120: script.write(code)
Line 121: os.chmod(script.name, 0775)
Line 122: script.close()
Line 123:
Line 124: result = hooks._runHooksDir("oVirt", dirName,
test_runHooksDir does not test the availability of custom properties inside a
hook.
As we discussed in person, there is no real advantage to calling
before_nic_hotplug, as it is essentially the same as what's being done in this
test already.
Line 125: params={'customProperty': '
rocks!'})
--
To view, visit http://gerrit.ovirt.org/13124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1684c3bcf8838b43c7856f3794f1bffd8c4b28c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
