Dan Kenigsberg has posted comments on this change. Change subject: Work in progress: First commit for custom device properties. ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) minor comment .................................................... File vdsm/vdsmd.8.in Line 83: The environment of before_vm_set_ticket and after_vm_set_ticket hooks is augmented Line 84: with a set of params passed by the caller of setVmTicket. Line 85: Line 86: The environment of hooks specific to devices: Line 87: before_nic_hotplug, after_nic_hotplug, after_nic_hotplug_fail, please break these long line. Line 88: before_nic_hotunplug, after_nic_hotunplug, after_nic_unhotplug_fail, Line 89: before_disk_hotplug, after_disk_hotplug, Line 90: before_disk_hotunplug, after_disk_hotunplug. Line 91: -- To view, visit http://gerrit.ovirt.org/13124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1684c3bcf8838b43c7856f3794f1bffd8c4b28c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
