Dan Kenigsberg has posted comments on this change.
Change subject: Custom properties per device.
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/vdsmd.8.in
Line 88: before_nic_hotunplug, after_nic_hotunplug,
after_nic_unhotplug_fail,
Line 89: before_disk_hotplug, after_disk_hotplug,
Line 90: before_disk_hotunplug, after_disk_hotunplug.
Line 91:
Line 92: Are all augmented by custom properties specific to those devices,
note the evil trailing space.
Line 93: sent by the caller of the hook. For example if before_nic_hotplug is
called
Line 94: with custom: {qos: '0.5', color: 'red'} then qos and color will be
directly
Line 95: available as environment variables when before_nic_hotplug is called.
Line 96:
--
To view, visit http://gerrit.ovirt.org/13124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1684c3bcf8838b43c7856f3794f1bffd8c4b28c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
