Dan Kenigsberg has submitted this change and it was merged. Change subject: Custom properties per device. ......................................................................
Custom properties per device. This is the first commit in a series of patches that will implement custom properties per device. The first commit deals with hot plugging and unplugging devices and enabling custom properties for those hook points. Patch Set 1: 1) All methods related to nic and disk hot plug and unplug in hooks.py and libvirtvm.py now pass the params dictionary onwards. 2) Added unit test 'deviceCustomProperties' under hooksTests.py, that verifies that a custom property sent to a hook is indeed available in that hook. Patch Set 2: Updated the man page to reflect the fact that custom properties are now exposed as environment variables to device hooks Patch Set 3: Broke down long line in man page. Change-Id: Id1684c3bcf8838b43c7856f3794f1bffd8c4b28c Signed-off-by: Assaf Muller <[email protected]> --- M tests/hooksTests.py M vdsm/hooks.py M vdsm/libvirtvm.py M vdsm/vdsmd.8.in 4 files changed, 81 insertions(+), 31 deletions(-) Approvals: Assaf Muller: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1684c3bcf8838b43c7856f3794f1bffd8c4b28c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
