Zhou Zheng Sheng has posted comments on this change.

Change subject: vdsmd.init.in: simplify system services management by using 
vdsm-tool
......................................................................


Patch Set 1: (3 inline comments)

Thanks Dan. I refactor the libvirt Upstart configuration logic in the new patch 
set. I thought it was for Fedora 15. Now I know RHEL6 is the same on this 
problem.

....................................................
File vdsm/vdsmd.init.in
Line 140:     local ret_val
Line 141: 
Line 142:     for srv in $NEEDED_SERVICES
Line 143:     do
Line 144:         if ! /usr/bin/vdsm-tool service_status $srv > /dev/null 2>&1;
Done
Line 145:         then
Line 146:             echo "Starting $srv..."
Line 147:             /usr/bin/vdsm-tool service_start $srv
Line 148:             ret_val=$?


Line 157
Line 158
Line 159
Line 160
Line 161
Done


Line 393
Line 394
Line 395
Line 396
Line 397
Done

I thought this is for Fedora 15. Now you point out EL6 share the same problem, 
so I add it in the new patch set.


--
To view, visit http://gerrit.ovirt.org/13702
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57a89d969b8ff4eba57daa893dc29840358c30e7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to