Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: vdsmd.init.in: simplify system services management by using 
vdsm-tool
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/vdsmd.init.in
Line 162:             fi
Line 163:         fi
Line 164:     done
Line 165: 
Line 166:     @SERVICE_PATH@ iscsid force-start
What's @SERVICE_PATH@ here and does every service have force-start? Should 
vdsm-tool abstract this away as well?
Line 167: }
Line 168: 
Line 169: test_lo() {
Line 170:     if ! LC_ALL=C /sbin/ip link show lo | /bin/grep -q UP;


--
To view, visit http://gerrit.ovirt.org/13702
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57a89d969b8ff4eba57daa893dc29840358c30e7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to