Yaniv Bronhaim has posted comments on this change. Change subject: vdsmd.init.in: simplify system services management by using vdsm-tool ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (1 inline comment) .................................................... File vdsm/vdsmd.init.in Line 32: CORE_DUMP_PATH=/var/log/core/core.%p.%t.dump Line 33: DOM_METADATA_BACKUP_DIR=/var/log/vdsm/backup Line 34: CORE_PATTERN=/proc/sys/kernel/core_pattern Line 35: QEMU_DUMP_PATH="/var/log/core" Line 36: NEEDED_SERVICES="iscsid multipathd ntpd wdmd sanlock network libvirtd" we don't need to start libvirt as part of loading needed service. we call configure_libvirt that already does that Line 37: CONFLICTING_SERVICES="libvirt-guests" Line 38: Line 39: # trigger for reconfiguration Line 40: FORCE_RECONFIGURE=@VDSMLIBDIR@/reconfigure -- To view, visit http://gerrit.ovirt.org/13702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57a89d969b8ff4eba57daa893dc29840358c30e7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
