Mark Wu has posted comments on this change. Change subject: WIP: Introduce prepareForBackup vdsm verb ......................................................................
Patch Set 3: I would prefer that you didn't submit this Hi Deepak, When I review this patch, I get several questions about the design of backup solution. I know it's too late to raise design questions. So if they're already discussed before, you could just point me some references. 1. Why do we need using qemu-nbd for the case of 'VIRTAPP'. If I understand it correctly, we can attach the temp snapshot to the virtual backup appliance directly. Then the backup software can access the data of vm to be backuped. 2. Why do we choose qemu-nbd to export the temp snapshot for remote backup app? Can we restrict the backup server always can access the storage managed by oVirt directly? I know it loses the flexibility of exporting image via network, but it has a big improvement on performance, and also can offload the backup work from host to storage. Then it can avoid the impact on running vms caused by the backup. If it's difficult to expose a proper access permission of the share storage to the backup host, I would like to propose using iscsi or scp instead of qemu-nbd because the client is easier to setup and available across platforms. I don't know what platform most backup software running on. If you need file level backup, you could mount the guest disk via libguestfs. It can also handle the partitions and lvms inside guest disk. For qemu-nbd, you have to handle it by yourself. -- To view, visit http://gerrit.ovirt.org/14403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ccacda2b09810a71f445ed65de6a09336ea3fb1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
