Mark Wu has posted comments on this change.
Change subject: NetReload: netmodels for addNetwork
......................................................................
Patch Set 12: (1 inline comment)
....................................................
File vdsm/netmodels.py
Line 109: '''This class represents traditional kernel bridges.'''
Line 110: MAX_BRIDGE_NAME_LEN = 15
Line 111: ILLEGAL_BRIDGE_CHARS = frozenset(':. \t')
Line 112:
Line 113: def __init__(self, name, configurator, ipconfig=None, mtu=None,
port=None,
what is nicless bridge used for? For libvirt isolated or NAT network, the
bridge is managed by libvirt, not related to host network configuration. So
why do we need nicless bridge?
Line 114: forwardDelay=0, stp=None):
Line 115: self.validateName(name)
Line 116: self.port = port
Line 117: self.forwardDelay = forwardDelay
--
To view, visit http://gerrit.ovirt.org/14303
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
