Mark Wu has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ......................................................................
Patch Set 12: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/netmodels.py Line 298: def getConfig(self): Line 299: try: Line 300: ipaddr = self.ip.inet.address Line 301: netmask = self.ip.inet.netmask Line 302: gateway = self.ip.inet.gateway should be ipaddr = self.inet.address netmask = self.inet.netmask gateway = self.inet.gateway right? Line 303: except AttributeError: Line 304: ipaddr = netmask = gateway = None Line 305: bootproto = self.bootproto -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches