Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for addNetwork
......................................................................
Patch Set 12: (2 inline comments)
....................................................
File vdsm/netconf/ifcfg.py
Line 73: ifdown(bridge.name)
Line 74: if bridge.port:
Line 75: bridge.port.configure(bridge=bridge.name, **opts)
Line 76: ifup(bridge.name, bootproto == 'dhcp' and
Line 77: not utils.tobool(opts.get('blockingdhcp')))
Right. I'll move it to the IpConfig.
Line 78: self.configWriter.createLibvirtNetwork(network, True)
Line 79: self._libvirtAdded.add(bridge.name)
Line 80:
Line 81: def configureVlan(self, vlan, network=None, bridge=None, **opts):
Line 100: netmask=netmask, gateway=gateway,
Line 101: bootproto=bootproto, **opts)
Line 102: # take down nics that need to be changed
Line 103: _netinfo = netinfo.NetInfo()
Line 104: vlanedIfaces = [v['iface'] for v in _netinfo.vlans.values()]
Done
Line 105: if bond.name not in vlanedIfaces:
Line 106: for slave in bond.slaves:
Line 107: if slave.name not in vlanedIfaces:
Line 108: ifdown(slave.name)
--
To view, visit http://gerrit.ovirt.org/14303
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
