Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ......................................................................
Patch Set 16: (2 inline comments) .................................................... File vdsm/netconf/ifcfg.py Line 95: self.configWriter.addBonding(bond.name, bridge=bridge, Line 96: bondingOptions=bond.options, Line 97: mtu=bond.mtu, ipaddr=ipaddr, Line 98: netmask=netmask, gateway=gateway, Line 99: bootproto=bootproto, **opts) I did some testing with a previous version and the master behavior is: Bond0 has eth2 and eth3 with ip 192.168.1.14/24 (done by using iproute2 cmdline). If I add a bridgeless network 'foo' on bond0 with eth2 and eth3 and with ip 172.16.0.2/16, the new ip conf gets written on /etc/sysconfig/network-scripts/ifcfg-bond0 but the the new IP is set besides the old one, not replacing it (just like in this patchset). For nics though we need to do the flushing. Line 100: for slave in bond.slaves: Line 101: slave.configure(bonding=bond.name, **opts) Line 102: ifup(bond.name, async) Line 103: if network: .................................................... File vdsm/netmodels.py Line 140: Line 141: Line 142: class Bond(NetDevice): Line 143: def __init__(self, name, configurator, ipconfig=None, mtu=None, slaves=(), Line 144: options='mode=802.3ad miimon=150'): Done Line 145: self.validateName(name) Line 146: self.slaves = slaves Line 147: if options: Line 148: self.validateOptions(name, options) -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
