Mark Wu has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ......................................................................
Patch Set 19: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/netmodels.py Line 167: slaves = [] Line 168: for nic in nics: Line 169: nicVlans = tuple(_netinfo.getVlansForIface(nic)) Line 170: nicNet = _netinfo.getNetworkForIface(nic) Line 171: nicBond = _netinfo.getBondingForNic(name) should be nicBond = _netinfo.getBondingForNic(nic). Sorry not finding this problem before. It also could be a mistake existing in my suggestions. Line 172: if nicVlans or nicNet or nicBond and nicBond != name: Line 173: raise ConfigNetworkError( Line 174: ne.ERR_USED_NIC, 'nic %s already used by %s' % Line 175: (nic, nicVlans or nicNet or nicBond)) -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
