Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ......................................................................
Patch Set 17: (1 inline comment) .................................................... File vdsm/netconf/ifcfg.py Line 95: bondingOptions=bond.options, Line 96: mtu=bond.mtu, ipaddr=ipaddr, Line 97: netmask=netmask, gateway=gateway, Line 98: bootproto=bootproto, **opts) Line 99: if not netinfo.isVlanned(bond.name): This check is still necessary because Bond.objectivize can be used with implicit bonding. Line 100: for slave in bond.slaves: Line 101: if not netinfo.isVlanned(slave.name): Line 102: ifdown(slave.name) Line 103: for slave in bond.slaves: -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches