Antoni Segura Puimedon has posted comments on this change.

Change subject: Simplify setNewMtu()
......................................................................


Patch Set 8: (1 inline comment)

....................................................
File vdsm/netconf/ifcfg.py
Line 179:             self.configWriter.removeIpConfig(iface.name)
Line 180:         elif isinstance(iface.master, Bridge):
Line 181:             self.configWriter.removeBridgeMaster(iface.name)
Line 182:         multiple_usage = _netinfo.ifaceUsers(iface.name)
Line 183:         yield not multiple_usage
Done
Line 184: 
Line 185:         if multiple_usage:
Line 186:             self._setNewMtu(iface, _netinfo)
Line 187:             ifup(iface.name)


-- 
To view, visit http://gerrit.ovirt.org/15355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32e8e0d45b7887af8fd1b003fd4c358826b77289
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to