Giuseppe Vallarelli has posted comments on this change. Change subject: Simplify setNewMtu() ......................................................................
Patch Set 10: (1 inline comment) Looks good to me, just a minor comment. .................................................... File vdsm/netconf/ifcfg.py Line 29: import shutil Line 30: import threading Line 31: Line 32: from neterrors import ConfigNetworkError Line 33: from storage.misc import execCmd I know it's not part of the change set but shall we use the execCmd in vdsm.utils instead of this one from storage ? Line 34: from vdsm import constants Line 35: from vdsm import libvirtconnection Line 36: from vdsm import netinfo Line 37: from vdsm import utils -- To view, visit http://gerrit.ovirt.org/15355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32e8e0d45b7887af8fd1b003fd4c358826b77289 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
