Antoni Segura Puimedon has posted comments on this change.

Change subject: Simplify setNewMtu()
......................................................................


Patch Set 8: (1 inline comment)

....................................................
File lib/vdsm/netinfo.py
Line 519: 
Line 520:     def getVlansForIface(self, iface):
Line 521:         for v, vdict in self.vlans.iteritems():
Line 522:             if iface == vdict['iface']:
Line 523:                 yield v
I believe that this belongs to the next patch. Must have been a mistake when 
splitting the change into different patches.
Line 524: 
Line 525:     def getNetworkForIface(self, iface):
Line 526:         """ Return the network attached to nic/bond """
Line 527:         for network, netdict in self.networks.iteritems():


-- 
To view, visit http://gerrit.ovirt.org/15355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32e8e0d45b7887af8fd1b003fd4c358826b77289
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to