Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd.init: Add init adapter
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/init/daemonAdapter
Line 38: help='Ajust nice according to configuration
file')
Line 39: parser.add_argument('-r', '--respawn-pid-file',
dest='respawnPidFile',
Line 40: default=None, metavar='respawn_pid_file_path',
Line 41: help='Run with respawn watchdog protection and
'
Line 42: 'specify the respawn pid file path')
> I still cannot understand how can it create the file at /var/run if it was
> not created first by root and chown.
I do now... vdsm project is assuming that /var/run is persistent.
# rpm -qvl vdsm | grep /var/run
drwxr-xr-x 2 vdsm kvm 0 Mar 14 12:32
/var/run/vdsm
drwxr-xr-x 2 vdsm kvm 0 Mar 14 12:32
/var/run/vdsm/payload
drwxr-xr-x 2 vdsm kvm 0 Mar 14 12:32
/var/run/vdsm/pools
This assumption is incorrect in most modern distributions.
Line 43: args = parser.parse_args(sys.argv[1:])
Line 44: return args
Line 45:
Line 46: if __name__ == '__main__':
--
To view, visit http://gerrit.ovirt.org/15578
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
