Alon Bar-Lev has posted comments on this change. Change subject: vdsmd.init: Add init adapter ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/vdsmd.service.in Line 6: Line 7: [Service] Line 8: Type=simple Line 9: EnvironmentFile=-/etc/sysconfig/vdsm Line 10: ExecStartPre=@VDSMDIR@/init/run_task.sh pre-start "run_init_hooks gencerts libvirt_reconfigure syslog_available nwfilter dummybr load_needed_modules tune_system mkdirs test_space test_lo test_conflicting_conf" And... if these requires only for sysv, then just move the code into the init.d script... no? Line 11: ExecStart=@PYTHON@ @VDSMDIR@/init/daemonAdapter -u vdsm -n Line 12: ExecStopPost=@VDSMDIR@/init/run_task.sh post-stop "run_final_hooks" Line 13: KillMode=process Line 14: Restart=always -- To view, visit http://gerrit.ovirt.org/15578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
