Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd.init: Add init adapter
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/vdsmd.init.in
Line 52: start() {
Line 53: test_already_running && return 0
Line 54:
Line 55: if ! "@VDSMDIR@/init/run_task.sh" --pre-start --include \
Line 56: "shutdown_conflicting_srv start_needed_srv" ; then
and are you sure the name of the dependency are the same in debian? I kind of
think that the dependency mechanism will be different in any case (including
the way you start the dependency or check for status.
Well, I do see that we use vdsm-tool as abstraction layer, but I am unsure it
is required.
Anyway, if you going to leave this as-is, I suggest that the service names of
dependencies and conflicts will be provided here.
NEEDED_SERVICES="x y z" CONFLICTING_SERVICES="a b c"
"@{VDSMDIR}/init/run_task.sh" ...
Not critical issue.
Line 57: log_failure_msg "$prog: failed to execute initialization tasks"
Line 58: return 1
Line 59: fi
Line 60:
--
To view, visit http://gerrit.ovirt.org/15578
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
