Dan Kenigsberg has posted comments on this change.

Change subject: Qos feature: Adds bandwidth definition at configuration level.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File tests/netconfTests.py
Line 146:                             <name>%s</name>
Line 147:                             <forward mode='passthrough'/>
Line 148:                             <interface dev='%s'/>
Line 149:                           </network>""" % (netName, iface))
Line 150:         actualDoc = self.cw.createNetXml(netName, None, False, iface)
oh, sorry for confusing your new createNetXml with the older 
createLibvirtNetwork.
Line 151: 
Line 152:         self.assertEqualXml(expectedDoc, actualDoc)
Line 153: 
Line 154:     def testCreateNetXmlBridgedQos(self):


-- 
To view, visit http://gerrit.ovirt.org/15724
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0c3b4b9a6fd5eb53579fb2e157b5325caa88d04
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvall...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to