Dan Kenigsberg has posted comments on this change. Change subject: Qos feature: Adds bandwidth definition at configuration level. ......................................................................
Patch Set 3: I would prefer that you didn't submit this (4 inline comments) Thanks for your fixes and answers. BTW you are in a race condition with http://gerrit.ovirt.org/#/c/15178/ . .................................................... File vdsm_api/vdsmapi-schema.json Line 168: # @onboot: #optional Start the network device automatically during boot Line 169: # Line 170: # @remove: #optional If True, remove existing network only Line 171: # Line 172: # @qosInbound: #optional VmInterfaceDeviceBandwidthParams for incoming traffic. I understand that it affects the formerly-defined usage of VmInterfaceDeviceBandwidthParams, but no one in the universe has used it yet. Your current usage for it does not fit the name - so I think that a simple BandwidthParams is better. Maybe others have better ideas. Line 173: # Line 174: # @qosOutbound: #optional VmInterfaceDeviceBandwidthParams for outgoing traffic. Line 175: # Line 176: # Since: 4.10.0 .................................................... File vdsm/netconf/ifcfg.py Line 17: # Refer to the README and COPYING files for full details of the license Line 18: # Line 19: Line 20: from xml.sax.saxutils import escape Line 21: from xml.etree.ElementTree import Element as XmlElement, tostring Would you agree to use xml.dom.minidom instead? That's what we do extensively in vm.py, and I hate to link with another library in parallel. (yes, I know that we already have this unfortunate dependency in vdsm-gluster; I have a vague memory of Bala promising to pull it away) I'm not even sure if simple string-mangling is not enough in this case, but that's probably a matter of taste. Line 22: import glob Line 23: import libvirt Line 24: import logging Line 25: import os Line 245: net = conn.networkDefineXML(netXml) Line 246: net.create() Line 247: net.setAutostart(1) Line 248: Line 249: def createNetXml(self, netName, network, bridged, iface, I think that createNetXml should be declared _private as it is just a helper of createLibvirtNetwork. Line 250: qosInbound=None, qosOutbound=None): Line 251: """ Line 252: Creates Network Xml e.g.: Line 253: <network> Line 598: onboot='yes', **kwargs): Line 599: """ Create ifcfg-* file with proper fields for VLAN """ Line 600: conf = 'VLAN=yes\n' Line 601: if bridge: Line 602: conf += 'BRIDGE=%s\n' % pipes.quote(bridge) unrelated deletion. Line 603: self._createConfFile(conf, vlan, ipaddr, netmask, gateway, Line 604: bootproto, mtu, onboot, **kwargs) Line 605: Line 606: def addBonding(self, bonding, bridge=None, bondingOptions=None, mtu=None, -- To view, visit http://gerrit.ovirt.org/15724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0c3b4b9a6fd5eb53579fb2e157b5325caa88d04 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
