Giuseppe Vallarelli has posted comments on this change. Change subject: Qos feature: Adds bandwidth definition at configuration level. ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm/netconf/ifcfg.py Line 17: # Refer to the README and COPYING files for full details of the license Line 18: # Line 19: Line 20: from xml.sax.saxutils import escape Line 21: from xml.etree.ElementTree import Element as XmlElement, tostring With ElementTree I can create an Element and provide the attributes as a dict see implementation below it's much easier, minidom is too much limited http://docs.python.org/2/library/xml.dom.minidom.html Line 22: import glob Line 23: import libvirt Line 24: import logging Line 25: import os -- To view, visit http://gerrit.ovirt.org/15724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0c3b4b9a6fd5eb53579fb2e157b5325caa88d04 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
