Giuseppe Vallarelli has posted comments on this change. Change subject: configNetwork: fix handleBondings regression ......................................................................
Patch Set 3: I would prefer that you didn't submit this (2 inline comments) See comment in networkTests. .................................................... File tests/functional/networkTests.py Line 45: @cleanupNet Line 46: @permutations([[True], [False]]) Line 47: @RequireDummyMod Line 48: @ValidateRunningAsRoot Line 49: def testAddDelBondedNetwork(self, bridged): Guess this is not the appropriate test to catch the failure you're covering. _handleBondings is called within setupNetworks. Line 50: with dummyIf(2) as nics: Line 51: status, msg = self.vdsm_net.addNetwork(NETWORK_NAME, Line 52: bond=BONDING_NAME, Line 53: nics=nics, .................................................... File tests/functional/utils.py Line 153: Line 154: def bondExists(self, bond_name, nics=None): Line 155: info = netinfo.NetInfo(self.vdscli.getVdsCapabilities()['info']) Line 156: return bond_name in info.bondings and \ Line 157: (not nics or set(nics) == set(info.bondings[bond_name]['slaves'])) Nice method! -- To view, visit http://gerrit.ovirt.org/15902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19dc94938be094bfe990301aab49a1ddc01e72fc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
