Giuseppe Vallarelli has posted comments on this change.
Change subject: configNetwork: fix handleBondings regression
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File tests/functional/networkTests.py
Line 69: @ValidateRunningAsRoot
Line 70: def testSetupNetworksAddOverExistingBond(self, bridged=True):
Line 71: with dummyIf(2) as nics:
Line 72: status, msg = self.vdsm_net.setupNetworks(
Line 73: {}, {BONDING_NAME: {'nics': nics}},
Can you add paramname=value ? This way it's easier to understand instead of
remembering the setupNetworks API.
Line 74: {'connectivityCheck': False})
Line 75: self.assertEqual(status, SUCCESS, msg)
Line 76: self.assertTrue(self.vdsm_net.bondExists(BONDING_NAME,
nics))
Line 77:
....................................................
File tests/functional/utils.py
Line 164: info =
netinfo.NetInfo(self.vdscli.getVdsCapabilities()['info'])
Line 165: return bond_name in info.bondings and \
Line 166: (not nics or set(nics) ==
set(info.bondings[bond_name]['slaves']))
Line 167:
Line 168: class Pinger(object):
You can either nest this class within VdsProxy or use contextmanager (as you
know I like the second choice more).
Line 169: def __init__(self, vdsclient):
Line 170: self.vdscli = vdsclient
Line 171:
Line 172: def ping(self):
--
To view, visit http://gerrit.ovirt.org/15902
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19dc94938be094bfe990301aab49a1ddc01e72fc
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
