Dan Kenigsberg has posted comments on this change. Change subject: configNetwork: fix handleBondings regression ......................................................................
Patch Set 7: I would prefer that you didn't submit this (1 inline comment) Thanks for the added test! It would help us catching such regressions earlier. But one question/suggestion withing. .................................................... File tests/functional/utils.py Line 171: while not self._done: Line 172: self.vdscli.ping() Line 173: time.sleep(1) Line 174: try: Line 175: self._done = False I have a thing against introducing args outside __init__. Here, it is even worse since "_done" is not really an attr of the proxy object. Can we make it a pinger()-local variable? The locally-defined ping() function could still access it. Line 176: pinger_thread = threading.Thread(target=ping) Line 177: pinger_thread.start() Line 178: yield Line 179: except Exception: -- To view, visit http://gerrit.ovirt.org/15902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19dc94938be094bfe990301aab49a1ddc01e72fc Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
