Dan Kenigsberg has submitted this change and it was merged. Change subject: configNetwork: fix handleBondings regression ......................................................................
configNetwork: fix handleBondings regression during the rebase destroy was not updated to its new name of destroyOnRemoval. This patch fixes that. Patch Set 2: - Added a functional test to catch this sort of problem in the future. Patch Set 3: - Fixed arguments. Patch Set 4: - Added extra tests. Patch Set 5: - Improvement on the tests. Patch Set 6: - Fixed pep8. Patch Set 7: - simplified pinger. Patch Set 8: - Cleaned the pinger implementation. Change-Id: I19dc94938be094bfe990301aab49a1ddc01e72fc Signed-off-by: Antoni S. Puimedon <[email protected]> Reviewed-on: http://gerrit.ovirt.org/15902 Reviewed-by: Dan Kenigsberg <[email protected]> --- M tests/functional/networkTests.py M tests/functional/utils.py M vdsm/configNetwork.py 3 files changed, 103 insertions(+), 3 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19dc94938be094bfe990301aab49a1ddc01e72fc Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
