Giuseppe Vallarelli has posted comments on this change. Change subject: Hidden bonds[2/2]: Refactored and updated nics implementation. ......................................................................
Patch Set 5: (1 inline comment) .................................................... File tests/netinfoTests.py Line 109: Creates test fixture which is a dir structure: Line 110: em, me, fake0, fake1 devices that should managed by vdsm. Line 111: hid0, hideons not managed by being hidden nics. Line 112: jbond not managed by being hidden bond. Line 113: me0, me1 not managed by being nics enslaved to hidden bond. Docstring needs a fix is not fake1 but fake. Line 114: /tmp/.../em/device Line 115: /tmp/.../me/device Line 116: /tmp/.../fake0 Line 117: /tmp/.../fake1 -- To view, visit http://gerrit.ovirt.org/16239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieab80a3ca6b243ade75e490b7004bebe96248140 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
