Antoni Segura Puimedon has posted comments on this change. Change subject: Hidden bonds[2/2]: Refactored and updated nics implementation. ......................................................................
Patch Set 5: (1 inline comment) .................................................... File lib/vdsm/netinfo.py Line 133: if not _match_name(bond, hidden_bonds): Line 134: res.append(bond) Line 135: except IOError as e: Line 136: if e.errno == os.errno.ENOENT: Line 137: return res Nevermind. I guess that we either get the exception when opening and starting to read the file or not at all. Line 138: else: Line 139: raise Line 140: Line 141: return res -- To view, visit http://gerrit.ovirt.org/16239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieab80a3ca6b243ade75e490b7004bebe96248140 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
