Giuseppe Vallarelli has posted comments on this change. Change subject: Hidden bonds[2/2]: Refactored and updated nics implementation. ......................................................................
Patch Set 5: (1 inline comment) .................................................... File lib/vdsm/netinfo.py Line 100: if device in slaves(bond): Line 101: return False Line 102: return True Line 103: Line 104: def predicate(device): I've found a better name I'll change it. Line 105: """Returns boolean stating if a device should be managed by vdsm.""" Line 106: if isFakeNic(device): Line 107: return True Line 108: elif (isVisibleNic(device) and -- To view, visit http://gerrit.ovirt.org/16239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieab80a3ca6b243ade75e490b7004bebe96248140 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
