Antoni Segura Puimedon has posted comments on this change. Change subject: Add iproute2 configurator ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) Apart from the comment, it is probable that it will need a rebase after the patch that simplifies the configurator parameters for configureNic, configureBond, etc. .................................................... File lib/vdsm/ipwrapper.py Line 245: command += rule Line 246: _execCmd(command) Line 247: Line 248: Line 249: def addrAdd(addr): All these methods perform actions rather than get information. Thus, we do not care about the result and shouldn't return anything. Line 250: command = [_IP_BINARY.cmd, 'addr', 'add'] + addr Line 251: return _execCmd(command) Line 252: Line 253: -- To view, visit http://gerrit.ovirt.org/15301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I762cfa30f78c5a46507b86f53e98bcf79dfc5844 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
