Dan Kenigsberg has posted comments on this change.
Change subject: Hidden bonds[2/2]: Refactored and updated nics implementation.
......................................................................
Patch Set 8: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File lib/vdsm/config.py.in
Line 66: ('hidden_nics', 'wlan*,usb*',
Line 67: 'Comma-separated list of fnmatch-patterns for host nics to
be '
Line 68: 'hidden from vdsm.'),
Line 69:
Line 70: ('hidden_bonds', 'bond*',
this is a bad default. We do *not* want to hide all bonds... Better keep it
empty.
Line 71: 'Comma-separated list of fnmatch-patterns for host bonds
to be '
Line 72: 'hidden from vdsm.'),
Line 73:
Line 74: ('default_bridge', 'engine', None),
....................................................
File lib/vdsm/netinfo.py
Line 88:
Line 89: def isHiddenBond(device):
Line 90: return _match_name(device, hidden_bonds)
Line 91:
Line 92: def isNotEnslavedByHiddenBond(device):
I dislike negations in function names. They are confusing; I do not see why is
it helpful (avoiding one bitwise logical operation?)
Line 93: """
Line 94: Returns boolean stating if nic is not enslaved to an hidden
bond.
Line 95: """
Line 96: for bond_fn in hidden_bonds:
--
To view, visit http://gerrit.ovirt.org/16239
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieab80a3ca6b243ade75e490b7004bebe96248140
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
