Yaniv Bronhaim has posted comments on this change.
Change subject: Extend vdsm-tool: moving configure libvirt to external shell
script
......................................................................
Patch Set 23: (1 inline comment)
....................................................
File lib/vdsm/tool/libvirt_configure.sh.in
Line 119: /bin/grep -q "^\s*${key}\s*=" "${cfile}" || \
Line 120: echo "${key}=${val}" >> "${cfile}"
Line 121: }
Line 122:
Line 123: isOvirt() {
this imported from ovirt_functions.sh. I remove that declaration
Line 124: [ "$(echo /etc/ovirt-node-*-release)" !=
"/etc/ovirt-node-*-release" ] || \
Line 125: [ -f /etc/rhev-hypervisor-release ]
Line 126: }
Line 127:
--
To view, visit http://gerrit.ovirt.org/15216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id58b129afbf141a47a85b421961bf5b1776b41e4
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
