Dan Kenigsberg has posted comments on this change.
Change subject: Extend vdsm-tool: moving configure libvirt to external shell
script
......................................................................
Patch Set 21: (2 inline comments)
....................................................
File lib/vdsm/tool/libvirt_configure.sh.in
Line 122: [ "$(echo /etc/ovirt-node-*-release)" !=
"/etc/ovirt-node-*-release" ] || \
Line 123: [ -f /etc/rhev-hypervisor-release ]
Line 124: }
Line 125:
Line 126: start_configure() {
naming: why is this called *start_*configure? is there a second phase hiding
somewhere?
It's ok to keep this function long and confusing for now; I hope that future
patches breaks it to simpler independent functions.
Line 127: # if SysV init file and Upstart job file both exist, prefer
Upstart
Line 128: libvirtd_sysv2upstart || return $?
Line 129:
Line 130: local lconf="$1"
Line 242: local llogr=/etc/logrotate.d/libvirtd
Line 243: local stanza=`mktemp`
Line 244: /bin/cat > "${stanza}" <<EOF
Line 245: # vdsm
Line 246: /var/log/libvirt/libvirtd.log {
FYI: please note that we have a known bug regarding this line
http://gerrit.ovirt.org/16528
Line 247: rotate 100
Line 248: missingok
Line 249: copytruncate
Line 250: size 15M
--
To view, visit http://gerrit.ovirt.org/15216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id58b129afbf141a47a85b421961bf5b1776b41e4
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
