Dan Kenigsberg has posted comments on this change. Change subject: Extend vdsm-tool: moving configure libvirt to external shell script ......................................................................
Patch Set 24: (1 inline comment) .................................................... File lib/vdsm/tool/libvirt_configure.sh.in Line 17: # Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: Line 21: . @LIBEXECDIR@/ovirt_functions.sh both are needed. /usr/libexec/vdsm/ovirt_functions.sh is one thing (shipped with vdsm) and /usr/libexec/ovirt-functions is something else (shipped with ovirt-node). Line 22: Line 23: GETCONFITEM="@VDSMDIR@/get-conf-item" Line 24: VDSM_CONF_FILE="@CONFDIR@/vdsm.conf" Line 25: QEMU_DUMP_PATH="/var/log/core" -- To view, visit http://gerrit.ovirt.org/15216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id58b129afbf141a47a85b421961bf5b1776b41e4 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
