Dan Kenigsberg has submitted this change and it was merged. Change subject: Decoupling libvirtconnection.py from clientIF.py ......................................................................
Decoupling libvirtconnection.py from clientIF.py 1.) Decoupling libvirtconnection.py from clientIF.py adding libvirt cb handlers for vm events belongs in vm.py 2.) bugfix: not all libviryconnecition.get() invocations from vdsm are wrapped with error handling code (with an important implication in the bug description: causes vdsm to shutdown on libvirt connection error) These two come in the same patch because removing the cif dependency (clientIF instance) from libvirtconnection must handle errors in a new way - sendind SIGTERM to the current process which solves the bug. Change-Id: Ibc550ea40ebb3abcf37ebfa59cbf8df8e42daa96 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=958367 Signed-off-by: Mooli Tayer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/16393 Reviewed-by: Dan Kenigsberg <[email protected]> --- M lib/vdsm/libvirtconnection.py M lib/vdsm/tool/dummybr.py M lib/vdsm/tool/nwfilter.py M tests/vmTests.py M vdsm/clientIF.py 5 files changed, 81 insertions(+), 65 deletions(-) Approvals: mooli tayer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc550ea40ebb3abcf37ebfa59cbf8df8e42daa96 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
