Dan Kenigsberg has posted comments on this change. Change subject: Decoupling libvirtconnection.py from clintIF.py ......................................................................
Patch Set 2: (1 inline comment) .................................................... Commit Message Line 14: causes vdsm to shutdown on libvirt connection error) Line 15: Line 16: These two come in the same patch because removing Line 17: the cif dependency (clientIF instance) from libvirtconnection Line 18: must handle errors in a new way - sendind SIGTERM to the current Sorry, I've missed your response to my comment. I cannot say that I am convinced - since these are two different changes to solve one bug. Anyway, I can live with keeping the current cludge. Line 19: process which solves the bug. Line 20: Line 21: Change-Id: Ibc550ea40ebb3abcf37ebfa59cbf8df8e42daa96 Line 22: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=958367 -- To view, visit http://gerrit.ovirt.org/16393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc550ea40ebb3abcf37ebfa59cbf8df8e42daa96 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
