Dan Kenigsberg has posted comments on this change. Change subject: Decoupling libvirtconnection.py from clientIF.py ......................................................................
Patch Set 5: I would prefer that you didn't submit this (1 inline comment) .................................................... File lib/vdsm/libvirtconnection.py Line 140: conn.domainEventRegisterAny(None, Line 141: ev, Line 142: target.dispatchLibvirtEvents, Line 143: ev) Line 144: # In case we're running into troubles with This comment is actually not related to this conditional. Better keep it in its original indentation. Line 145: # keeping the connections alive we should place here: Line 146: # conn.setKeepAlive(interval=5, count=3) Line 147: # However the values need to be Line 148: # considered wisely to not affect -- To view, visit http://gerrit.ovirt.org/16393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc550ea40ebb3abcf37ebfa59cbf8df8e42daa96 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
