Ayal Baron has posted comments on this change.
Change subject: mount: Reassign mount specification in case of backup option
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/storageServer.py
Line 269: return
Line 270:
Line 271: backupSpec = self._getBackupSpec()
Line 272: if backupSpec:
Line 273: if mount.Mount(backupSpec,
self._mount.fs_file).isMounted():
backupvolfile-server specifies an alternative to the main mount path in case
the latter fails in mounting. By default, if mount to the regular path
succeeds then backupSpec would not be mounted.
IIUC here you expect it always to be mounted which is incorrect.
We should only check it if _validateMountPoint fails.
Line 274: self._mount.fs_spec = backupSpec
Line 275: else:
Line 276: self.log.warning("Mount of backup: %s to: %s failed",
Line 277: backupSpec, self._mount.fs_file)
--
To view, visit http://gerrit.ovirt.org/16534
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3166c6863dffa297bc0adcdeb4c22f810d18de8e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
