Yeela Kaplan has posted comments on this change. Change subject: mount: Reassign mount specification in case of backup option ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/storage/storageServer.py Line 269: return Line 270: Line 271: backupSpec = self._getBackupSpec() Line 272: if backupSpec: Line 273: if mount.Mount(backupSpec, self._mount.fs_file).isMounted(): 1. Currently only one backup option is available, but according to this bug recently opened it will change and be internal to gluster, trying multiple mount points, making it tricky for us to know the actual mount: https://bugzilla.redhat.com/show_bug.cgi?id=986429 2. ConnectionMonitor is not yet in use. But if it were then it serializes connection information sent from engine to vdsm. Engine is not aware of the actual mount connection available only in vdsm (since vdsm returns to engine only connection id), therefore we will persist the original connection and not only the backup. Line 274: self._mount.fs_spec = backupSpec Line 275: else: Line 276: self.log.warning("Mount of backup: %s to: %s failed", Line 277: backupSpec, self._mount.fs_file) -- To view, visit http://gerrit.ovirt.org/16534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3166c6863dffa297bc0adcdeb4c22f810d18de8e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
