Dan Kenigsberg has posted comments on this change. Change subject: Killing vdsm when first communication to libvirt fails ......................................................................
Patch Set 2: Code-Review-1 libvirtconnection is a helper module. it is highly non-conventional for such a module to kill its calling process. We were forced to do so when we had a single stale libvirtconnection shared among multiple VM objects in multiple threads. This is not the case when we are trying to get() our first libvirtconnection. It is much better practice for the caller of get() to handle the exception properly. In this case, it may terminate vdsm. Other users (e.g. sourceRoute) would opt to circumvent libvirt. -- To view, visit http://gerrit.ovirt.org/17617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80745e04c7cce50e4cd8ce12628131b76d0659a7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
