Yaniv Bronhaim has posted comments on this change.
Change subject: After exception on _recoverExistingVms thread we should try
again
......................................................................
Patch Set 5:
(1 comment)
....................................................
File vdsm/clientIF.py
Line 425: vdsmVms = self._getVDSMVms()
Line 426: #Recover
Line 427: for v in vdsmVms:
Line 428: vmId = v.UUIDString()
Line 429: if not self._recoverVm(vmId):
Its not relevant for this patch. I can submit such patch add jump logic over
stuck recoveries, but this one is about catching libvirt errors\other
exceptions that can be raised in this scope and try again instead of leaving
the thread and keep being stuck in initialization state.
Line 430: #RH qemu proc without recovery
Line 431: self.log.info('loose qemu process with id: '
Line 432: '%s found, killing it.', vmId)
Line 433: try:
--
To view, visit http://gerrit.ovirt.org/17617
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80745e04c7cce50e4cd8ce12628131b76d0659a7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
