Barak Azulay has posted comments on this change. Change subject: Killing vdsm when first communication to libvirt fails ......................................................................
Patch Set 3: Code-Review-1 This happens only when libvirt is stopped manually while vdsm is up, so vdsm will reset itself and it will be caught by the watchdog, so this fix will loop around reseting vdsm (not good) I think a better idea will be to loop over the libvirt connection on the recovering thread. this way the vdsm will still return the "recovering" status and the libvirt connection will be re-established after libvirt start -- To view, visit http://gerrit.ovirt.org/17617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80745e04c7cce50e4cd8ce12628131b76d0659a7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
