Timothy Asir has posted comments on this change.
Change subject: gluster Geo-replication: command to create and delete a
geo-replication session
......................................................................
Patch Set 8:
(3 comments)
....................................................
File vdsm/gluster/exception.py
Line 492: message = "Gluster Geo-Replication Exception"
Line 493:
Line 494:
Line 495: class
GlusterGeoRepPublicKeyFileCreationFailedException(GlusterGeoRepException
Line 496: ):
change the class name more consistent
you can change like GlusterGeoRepPublicKeyFileCreateFailedException
Line 497: code = 4561
Line 498: message = "Creation of public key file failed"
Line 499:
Line 500:
....................................................
File vdsm/gluster/vdsmapi-gluster-schema.json
Line 403: {'command': {'class': 'GlusterGeoRep', 'name': 'create'},
Line 404: 'data': {'masterVolName': 'str', 'slaveHost': 'str', 'slaveVolName':
'str', 'Force': 'bool'},
Line 405: 'returns': 'bool'}
Line 406:
Line 407:
remove this extra line
Line 408:
Line 409: ##
Line 410: # @GlusterGeoRep.delete:
Line 411: #
Line 417: #
Line 418: # @slaveVolName: is an available existing volume name in the slave
node
Line 419: #
Line 420: # Returns:
Line 421: # True if session is successfully Deleted
change the word 'Deleted' into 'deleted'
Line 422: #
Line 423: # Since: 4.10.3
Line 424: ##
Line 425: {'command': {'class': 'GlusterGeoRep', 'name': 'delete'},
--
To view, visit http://gerrit.ovirt.org/17644
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8c979a89ce11a1622819c474b59dcf088733594
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ndarshan <[email protected]>
Gerrit-Reviewer: Aravinda VK <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
