Timothy Asir has posted comments on this change.
Change subject: gluster Geo-replication: command to create and delete a
geo-replication session
......................................................................
Patch Set 8: Code-Review-1
(3 comments)
....................................................
File vdsm/gluster/vdsmapi-gluster-schema.json
Line 374: 'returns': 'GlusterServicesStatusInfo'}
Line 375:
Line 376: ## Category: @GlusterGeoReplication
######################################################
Line 377: ##
Line 378: # @GlusterGeoReplication:
Check the name and change accordingly.
you can change into "GlusterGeoRep"
Line 379: #
Line 380: # Gluster Geo Replication object.
Line 381: #
Line 382: # Since: 4.10.3
Line 392: # @mastervolname: is an existing volume name in the master node
Line 393: #
Line 394: # @slavehost: is remote slave host name or ip
Line 395: #
Line 396: # @slaveVolName: is an available existing volume name in the slave
node
use consistent casing
Line 397: #
Line 398: # Returns:
Line 399: # True if session is successfully created
Line 400: #
Line 400: #
Line 401: # Since: 4.10.3
Line 402: ##
Line 403: {'command': {'class': 'GlusterGeoRep', 'name': 'create'},
Line 404: 'data': {'masterVolName': 'str', 'slaveHost': 'str', 'slaveVolName':
'str', 'Force': 'bool'},
check the name "masterVolName", "slaveHost" which are not defined.
"Force" is not defined
Line 405: 'returns': 'bool'}
Line 406:
Line 407:
Line 408:
--
To view, visit http://gerrit.ovirt.org/17644
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8c979a89ce11a1622819c474b59dcf088733594
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ndarshan <[email protected]>
Gerrit-Reviewer: Aravinda VK <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
