Ayal Baron has posted comments on this change.
Change subject: Add support for transient disk
......................................................................
Patch Set 1:
(3 comments)
what prevents migration of a vm with a transient disk?
....................................................
File vdsm/vm.py
Line 1378: ((self.apparentsize + constants.MEGAB - 1) /
constants.MEGAB))
Line 1379:
Line 1380: @property
Line 1381: def networkDev(self):
Line 1382: if self.transientDisk:
how can you create a transient snap over a network disk that this is at all
relevant?
Line 1383: return False
Line 1384: try:
Line 1385: return self.volumeInfo['volType'] == "network"
Line 1386: except AttributeError:
Line 1391: def blockDev(self):
Line 1392: if self.networkDev:
Line 1393: return False
Line 1394: if self.transientDisk:
Line 1395: return False
this seems redundant as well as isBlockDevice should be false on self.path, no?
(and if we happen to support transient on block device then so be it)
Line 1396:
Line 1397: if self._blockDev is None:
Line 1398: try:
Line 1399: self._blockDev = utils.isBlockDevice(self.path)
Line 1401: self.log.debug("Unable to determine if the path '%s'
is a "
Line 1402: "block device", self.path,
exc_info=True)
Line 1403: return self._blockDev
Line 1404:
Line 1405: @property
if above 2 usages are redundant then no need for this property
Line 1406: def transientDisk(self):
Line 1407: try:
Line 1408: return self.transient
Line 1409: except AttributeError:
--
To view, visit http://gerrit.ovirt.org/18326
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
